|
Hi (again!)
I've only just started looking through the example code, and I see a few different coding styles. Not that I want to say ANYTHING bad about the amazing code you guys are writing, and please don't take this as criticism, but it would generally be easier to understand the examples if the coding style were a little more consistent.
e.g. (each entry represents a different file):
1 inputFilename
2 input_filename
and:
1 normalize_distance_matrix()
addDrums() <-- these two functions are in the same class
and,(I already mentioned this in my last mail):
1 input_filename_a = sys.argv[1]
2 input_filename_a = sys.argv[-4]
3 inputFilename = sys.argv[2]
4 inputFilename = sys.argv[-2]
An extra note to my last mail about command line args is that sometimes they are handled in main(), and sometimes after 'if name =='
and:
1 if units in ["tatums", "beats", "bars"]:
chunks = audiofile.analysis.getattribute(units)
2 if toReverse == 'beats' :
chunks = audioFile.analysis.beats
elif toReverse == 'segments' :
chunks = audioFile.analysis.segments
and:
1 if name == 'main':
import sys <--- after 'if name'
2 import sys <--- at top of file
and:
1 import lame, mad, numpy, eyeD3
2 import numpy
import sys
import time
Anyway, please don't hate me ;) I still have a_lot to learn about python, and I'm just trying to be consistent myself. My hat is off to you guys. Thanks for this amazing service, and I look forward to having some fun with it :)
Cheers,
Rich.
|